-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Restructure #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Restructure #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a109ffd
to
bb30510
Compare
bb30510
to
b30aefc
Compare
sr229
suggested changes
Feb 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks
This is mostly for development where VS Code might not have finished compiling yet.
cce282e
to
4cc181c
Compare
Otherwise there is risk of an infinite loop through the iframe where the fallback keeps loading the root HTML which itself has an iframe...
7147725
to
5baf166
Compare
Merged
Reworked from d574012 to fit in the new structure.
Now it should work whether you have a trailing slash or not.
We aren't providing binaries any longer.
302619e
to
18bbb28
Compare
Also fix padding not being respected when blocks exceed container height.
18bbb28
to
0e37201
Compare
We should still have an example gif @kylecarbs |
@nhooyr yup. Gunna add one |
To make installing as a PWA possible. Fixes #1181.
This was referenced Mar 2, 2020
Closed
Looks like sometimes VS Code throws strings. For example if ifconfig is missing.
In Firefox using the gzip mime type will (probably correctly) cause it not to decompress while in Chromium it still will (incorrectly).
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1302
Fixes #1233
Fixes #1303
Fixes #1298
Fixes #1035
Fixes #208
Fixes #1014
Fixes #1002
Fixes #1333
Fixes #1304
Fixes #1383
Fixes #1380